From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH] staging: fbtft: remove unused function fbtft_write_gpio16_wr_latched Date: Tue, 05 May 2026 10:41:28 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness:** Confirmed. A grep of the full kernel tree shows `fbtft_wri= te_gpio16_wr_latched` only appears in its definition (`fbtft-io.c:231`), it= s `EXPORT_SYMBOL` (`fbtft-io.c:236`), and its declaration (`fbtft.h:265`). = There are zero callers. **Patch is well-scoped:** It removes the function body and `EXPORT_SYMBOL` = from `fbtft-io.c`, and removes the declaration from `fbtft.h`. Both hunks a= re clean deletions with no surrounding changes. **Commit message:** Accurate and concise. Correctly notes the function is u= nreferenced and is a stub. **Minor nit (informational only):** The removed stub returns `-1` rather th= an a proper negative errno like `-ENOSYS`. This is a pre-existing style iss= ue that goes away with the removal, so no action needed =E2=80=94 just rein= forces that this dead code was never properly maintained. **No issues. Patch is ready to apply.** --- Generated by Claude Code Patch Reviewer