From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH 1/2] dt-bindings: display: panel: Document Tianma TA066VVHM03 Date: Mon, 09 Mar 2026 07:59:02 +1000 Message-ID: In-Reply-To: References: <20260308-tianma-ta066vvhm03-v1-0-869fac443b20@pm.me> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The binding looks reasonable overall but has one issue: **`enable-gpios` is optional in binding but required by the driver:** The binding does not list `enable-gpios` in the `required` section, yet the= driver in patch 2 uses `devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW)` whic= h will fail if the GPIO is not specified. Either add `enable-gpios` to the = `required` list in the binding, or make the driver use `devm_gpiod_get_opti= onal()`. Since the example DT node includes it and the driver needs it, add= ing it to `required` seems correct: ```yaml required: - compatible - reg - vddio-supply - vci-supply - vdd-supply - reset-gpios - port ``` Should also include `enable-gpios` here. Otherwise the binding is clean =E2=80=94 it uses `panel-common.yaml` refere= nce, has proper `additionalProperties: false`, and includes a complete exam= ple. --- --- Generated by Claude Code Patch Reviewer