From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: boe-bf060y8m-aj0: use devm_drm_panel_add() Date: Mon, 25 May 2026 16:58:17 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Good** The change replaces: ```c drm_panel_add(&boe->panel); ``` with: ```c ret =3D devm_drm_panel_add(dev, &boe->panel); if (ret) return ret; ``` and removes `drm_panel_remove(&boe->panel)` from the `remove` callback. This is correct. The `remove` callback is retained because this driver uses= manual `mipi_dsi_attach()` (not `devm_mipi_dsi_attach()`), so it still nee= ds its `mipi_dsi_detach()` call in `boe_bf060y8m_aj0_remove()`. The devres-= managed panel removal will happen automatically after `remove()` returns. **One minor observation**: The `boe_bf060y8m_aj0_remove()` callback now onl= y does `mipi_dsi_detach()` with error reporting. This is fine as-is, but a = potential follow-up could convert to `devm_mipi_dsi_attach()` and eliminate= the `remove` callback entirely =E2=80=94 though that's out of scope for th= is fix. The error handling for `devm_drm_panel_add()` failure (returning the error = code) is correct. No other cleanup is needed since all prior resource acqui= sitions in the probe function already use devres (`devm_gpiod_get`, `devm_d= rm_panel_alloc`, etc.). --- Generated by Claude Code Patch Reviewer