From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: jdi-lt070me05000: Transition to mipi_dsi *_multi() functions Date: Tue, 31 Mar 2026 17:44:36 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Verdict: Already applied (superseded), with several issues compared to th= e existing conversion.** The drm-next tree already contains this conversion (done more thoroughly). = Comparing the patch against the current tree reveals several shortcomings: 1. **Context variable naming**: The patch uses `ctx` while the tree uses `d= si_ctx`. Minor style difference, but indicates the patch was developed agai= nst a stale base. 2. **Sleep calls not converted**: The patch keeps bare `usleep_range()` and= `mdelay()`/`msleep()` calls: ```c usleep_range(10000, 20000); ... msleep(120); ... mdelay(10); ... mdelay(20); ``` The tree converts these to `mipi_dsi_usleep_range()` and `mipi_dsi_mslee= p()`, which properly short-circuit when `accum_err` is set, avoiding unnece= ssary delays after a failure. 3. **`mipi_dsi_generic_write_multi()` vs `mipi_dsi_generic_write_seq_multi(= )`**: The patch uses `mipi_dsi_generic_write_multi()` with explicit casts a= nd length parameters: ```c mipi_dsi_generic_write_multi(&ctx, (u8[]){0xB0, 0x00}, 2); ``` The tree uses the cleaner `mipi_dsi_generic_write_seq_multi()` macro whi= ch infers the length automatically: ```c mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xb0, 0x00); ``` This is both more readable and less error-prone (no risk of length misma= tch). 4. **Unused `dev` variable removal**: The patch removes `struct device *dev= =3D &jdi->dsi->dev;` which is correct since the `dev_err()` calls are remo= ved, but the existing tree also handles this properly. 5. **`jdi_panel_on()` and `jdi_panel_off()` not converted**: The patch only= converts `jdi_panel_init()`. The existing tree also converts `jdi_panel_on= ()` and `jdi_panel_off()` to use the multi context pattern, making it a mor= e complete conversion. **Summary**: This patch is redundant =E2=80=94 the work has already been me= rged in a better form. If it were being reviewed on its own merits, the fee= dback would be: use `mipi_dsi_*_seq_multi()` macros instead of raw `mipi_ds= i_generic_write_multi()`, convert the sleep calls to `mipi_dsi_msleep()`/`m= ipi_dsi_usleep_range()`, and extend the conversion to `jdi_panel_on()` and = `jdi_panel_off()` as well. --- Generated by Claude Code Patch Reviewer