From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Add new API analogix_dp_finish_probe() Date: Wed, 11 Feb 2026 16:37:17 +1000 Message-ID: In-Reply-To: <20260210071225.2566099-11-damon.ding@rock-chips.com> References: <20260210071225.2566099-1-damon.ding@rock-chips.com> <20260210071225.2566099-11-damon.ding@rock-chips.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailer: Claude Code Patch Reviewer Patch Review **Summary:** Adds new function to consolidate panel/bridge discovery with DP AUX bus population. ```c +static int analogix_dp_aux_done_probing(struct drm_dp_aux *aux) +{ + struct analogix_dp_device *dp = to_dp(aux); + struct analogix_dp_plat_data *plat_data = dp->plat_data; + int port = plat_data->dev_type == EXYNOS_DP ? 0 : 1; + int ret; + + ret = drm_of_find_panel_or_bridge(dp->dev->of_node, port, 0, + &plat_data->panel, &plat_data->next_bridge); + if (ret && ret != -ENODEV) + return ret; + + return component_add(dp->dev, plat_data->ops); +} ``` **Review:** - Good encapsulation of probe completion logic - Handles DP AUX bus properly with `devm_of_dp_aux_populate_bus` - Port selection logic (0 for Exynos, 1 for Rockchip) is a bit magical but documented **Verdict:** Approved, good API design. --- --- Generated by Claude Code Patch Reviewer