From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: mm/huge_memory: add page->private check back in __split_folio_to_order() Date: Tue, 24 Feb 2026 10:52:54 +1000 Message-ID: In-Reply-To: <20260223032641.1859381-11-ziy@nvidia.com> References: <20260223032641.1859381-1-ziy@nvidia.com> <20260223032641.1859381-11-ziy@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review > + /* > + * page->private should not be set in tail pages. Fix up and warn once > + * if private is unexpectedly set. Do it before swap.val assignment > + * since private overlaps with swap.val. > + */ > + if (unlikely(new_folio->private)) { > + VM_WARN_ON_ONCE_PAGE(true, new_head); > + new_folio->private = NULL; > + } > + > if (folio_test_swapcache(folio)) > new_folio->swap.val = folio->swap.val + i; The comment says "private overlaps with swap.val" and the check is placed before the swap.val assignment. If this is a swapcache folio, the swap.val assignment will overwrite private anyway. But for non-swapcache folios, if a tail page had unexpected private data, this catches and clears it. The logic is sound. The commit message says commit 4265d67e405a removed this check "without a proper reason." It would be helpful to explain what situation produces non-zero private in tail pages, rather than just asserting the prior commit was wrong. --- Generated by Claude Code Patch Reviewer