From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/arm: komeda: Convert to drm_output_color_format Date: Fri, 27 Feb 2026 15:17:09 +1000 Message-ID: In-Reply-To: <20260224-drm-rework-color-formats-v1-10-bebc76604ada@kernel.org> References: <20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org> <20260224-drm-rework-color-formats-v1-10-bebc76604ada@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Good conversion with both bitmask and discriminant contexts properly handled. The `komeda_improc_state` struct type change is clean: ```c - u8 color_format, color_depth; + enum drm_output_color_format color_format; + u8 color_depth; ``` The `komeda_pipeline_state.c` change is particularly noteworthy: ```c - st->color_format = BIT(__ffs(avail_formats)); + st->color_format = __ffs(avail_formats); ``` This is correct -- previously the field stored a bitmask value (single-bit), now it stores the enum value directly (the bit position). Good catch. **Same commit message typos.** --- Generated by Claude Code Patch Reviewer