From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: add gen_bootloader firmware to ModInfoBuilder Date: Tue, 03 Mar 2026 13:55:14 +1000 Message-ID: In-Reply-To: <20260301-turing_prep-v10-10-dde5ee437c60@nvidia.com> References: <20260301-turing_prep-v10-0-dde5ee437c60@nvidia.com> <20260301-turing_prep-v10-10-dde5ee437c60@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `needs_fwsec_bootloader()` to `Chipset`: ```rust pub(crate) const fn needs_fwsec_bootloader(self) -> bool { matches!(self.arch(), Architecture::Turing) || matches!(self, Self::GA100) } ``` And conditionally adds the `gen_bootloader` firmware entry for chipsets that need it. The `make_entry_chipset` method now takes a `Chipset` value instead of a `&str` to enable this conditional logic. The logic correctly identifies Turing and GA100 as the chipsets needing the bootloader (all chipsets < GA102 that use PIO loading). No issues. --- Generated by Claude Code Patch Reviewer