public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: lib/fonts: Compare font data for equality with font_data_is_equal()
Date: Tue, 10 Mar 2026 12:19:44 +1000	[thread overview]
Message-ID: <review-patch10-20260309141723.137364-11-tzimmermann@suse.de> (raw)
In-Reply-To: <20260309141723.137364-11-tzimmermann@suse.de>

Patch Review

The comment has a typo: "is constain" should be "it contains" and "also use" should be "also uses".

The function body:
```c
+	if (font_data_is_internal(lhs) != font_data_is_internal(rhs))
+		return false;
```
Good — prevents matching internal fonts to user-space copies, which would break refcounting.

However, removing the width check from fbcon:
```c
-		    tmp->vc_font.width == w &&
```
The commit message says "The test only compares data buffers. Their interpretation is up each console." But two fonts with different widths could have identical byte sequences yet represent completely different glyphs (different pitch/scanline layout). The `font_data_is_equal` check relies on same-size data implying same interpretation, but `size = height * pitch * charcount` — two fonts could have `(height=16, width=8, pitch=1, charcount=256)` vs `(height=8, width=16, pitch=2, charcount=128)`, both giving `size=4096` with potentially identical bytes but completely different visual results. This seems like a correctness concern.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-10  2:19 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09 14:14 [PATCH v3 00/13] vc,fbcon,fonts: Proper handling of font data Thomas Zimmermann
2026-03-09 14:14 ` [PATCH v3 01/13] fbdev: Declare src parameter of fb_pad_ helpers as constant Thomas Zimmermann
2026-03-10  2:19   ` Claude review: " Claude Code Review Bot
2026-03-09 14:14 ` [PATCH v3 02/13] vt: Remove trailing whitespaces Thomas Zimmermann
2026-03-10  2:19   ` Claude review: " Claude Code Review Bot
2026-03-09 14:14 ` [PATCH v3 03/13] vt: Store font in struct vc_font Thomas Zimmermann
2026-03-10  2:19   ` Claude review: " Claude Code Review Bot
2026-03-09 14:14 ` [PATCH v3 04/13] vt: Calculate font-buffer size with vc_font_size() Thomas Zimmermann
2026-03-10  2:19   ` Claude review: " Claude Code Review Bot
2026-03-09 14:14 ` [PATCH v3 05/13] lib/fonts: Remove trailing whitespaces Thomas Zimmermann
2026-03-10  2:19   ` Claude review: " Claude Code Review Bot
2026-03-09 14:14 ` [PATCH v3 06/13] lib/fonts: Remove FNTCHARCNT() Thomas Zimmermann
2026-03-10  2:19   ` Claude review: " Claude Code Review Bot
2026-03-09 14:14 ` [PATCH v3 07/13] lib/fonts: Store font data as font_data_t; update consoles Thomas Zimmermann
2026-03-10  2:19   ` Claude review: " Claude Code Review Bot
2026-03-09 14:14 ` [PATCH v3 08/13] lib/fonts: Read font size with font_data_size() Thomas Zimmermann
2026-03-10  2:19   ` Claude review: " Claude Code Review Bot
2026-03-09 14:14 ` [PATCH v3 09/13] lib/fonts: Manage font-data lifetime with font_data_get/_put() Thomas Zimmermann
2026-03-10  2:19   ` Claude review: " Claude Code Review Bot
2026-03-09 14:14 ` [PATCH v3 10/13] lib/fonts: Compare font data for equality with font_data_is_equal() Thomas Zimmermann
2026-03-10  2:19   ` Claude Code Review Bot [this message]
2026-03-09 14:14 ` [PATCH v3 11/13] lib/fonts: Create font_data_t from struct console_font with font_data_import() Thomas Zimmermann
2026-03-10  2:19   ` Claude review: " Claude Code Review Bot
2026-03-09 14:14 ` [PATCH v3 12/13] lib/fonts: Store font data for user space with font_data_export() Thomas Zimmermann
2026-03-10  2:19   ` Claude review: " Claude Code Review Bot
2026-03-09 14:14 ` [PATCH v3 13/13] lib/fonts: Remove internal symbols and macros from public header file Thomas Zimmermann
2026-03-10  2:19   ` Claude review: " Claude Code Review Bot
2026-03-09 14:48 ` [PATCH v3 00/13] vc,fbcon,fonts: Proper handling of font data Helge Deller
2026-03-10  2:19 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-02 14:08 [PATCH v2 00/13] " Thomas Zimmermann
2026-03-02 14:08 ` [PATCH v2 09/13] lib/fonts: Compare font data for equality with font_data_is_equal() Thomas Zimmermann
2026-03-03  3:19   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch10-20260309141723.137364-11-tzimmermann@suse.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox