public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/rockchip: dw_hdmi: avoid direct dereference of phy->dev.of_node
Date: Tue, 10 Mar 2026 11:57:16 +1000	[thread overview]
Message-ID: <review-patch10-20260309190842.927634-11-vladimir.oltean@nxp.com> (raw)
In-Reply-To: <20260309190842.927634-11-vladimir.oltean@nxp.com>

Patch Review

Replaces `hdmi->phy->dev.of_node` with a DT phandle lookup to get the PHY's OF node for clock provider resolution. The refactoring uses:
```c
index = of_property_match_string(np, "phy-names", "hdmi");
if (index >= 0) {
    if (!of_parse_phandle_with_args(np, "phys", "#phy-cells", index, &clkspec)) {
        hdmi->hdmiphy_clk = of_clk_get_from_provider(&clkspec);
        of_node_put(clkspec.np);
```

This is a clean approach. The original code checked `if (hdmi->phy)` whereas the new code checks `if (index >= 0)` — these should be equivalent since `hdmi->phy` comes from the same DT property lookup. The `of_node_put(clkspec.np)` is correctly added (the original code via `hdmi->phy->dev.of_node` didn't need it since it was a borrowed reference). No issues.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-10  1:57 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09 19:08 [PATCH v3 phy-next 00/24] Split Generic PHY consumer and provider API Vladimir Oltean
2026-03-09 19:08 ` [PATCH v3 phy-next 01/24] ata: add <linux/pm_runtime.h> where missing Vladimir Oltean
2026-03-10  1:57   ` Claude review: " Claude Code Review Bot
2026-03-09 19:08 ` [PATCH v3 phy-next 02/24] PCI: Add missing headers transitively included by <linux/phy/phy.h> Vladimir Oltean
2026-03-10  1:57   ` Claude review: " Claude Code Review Bot
2026-03-09 19:08 ` [PATCH v3 phy-next 03/24] usb: add " Vladimir Oltean
2026-03-10  1:57   ` Claude review: " Claude Code Review Bot
2026-03-09 19:08 ` [PATCH v3 phy-next 04/24] drm: add <linux/pm_runtime.h> where missing Vladimir Oltean
2026-03-10  1:57   ` Claude review: " Claude Code Review Bot
2026-03-09 19:08 ` [PATCH v3 phy-next 05/24] phy: " Vladimir Oltean
2026-03-10  1:57   ` Claude review: " Claude Code Review Bot
2026-03-09 19:08 ` [PATCH v3 phy-next 06/24] phy: spacemit: include missing <linux/phy/phy.h> Vladimir Oltean
2026-03-10  1:57   ` Claude review: " Claude Code Review Bot
2026-03-09 19:08 ` [PATCH v3 phy-next 07/24] net: lan969x: include missing <linux/of.h> Vladimir Oltean
2026-03-10  1:57   ` Claude review: " Claude Code Review Bot
2026-03-09 19:08 ` [PATCH v3 phy-next 08/24] PCI: Remove device links to PHY Vladimir Oltean
2026-03-10  1:57   ` Claude review: " Claude Code Review Bot
2026-03-09 19:08 ` [PATCH v3 phy-next 09/24] ufs: exynos: stop poking into struct phy guts Vladimir Oltean
2026-03-10  1:57   ` Claude review: " Claude Code Review Bot
2026-03-09 19:08 ` [PATCH v3 phy-next 10/24] drm/rockchip: dw_hdmi: avoid direct dereference of phy->dev.of_node Vladimir Oltean
2026-03-10  1:57   ` Claude Code Review Bot [this message]
2026-03-09 19:08 ` [PATCH v3 phy-next 11/24] drm/msm/dp: remove debugging prints with internal struct phy state Vladimir Oltean
2026-03-10  1:57   ` Claude review: " Claude Code Review Bot
2026-03-09 19:08 ` [PATCH v3 phy-next 12/24] phy: move provider API out of public <linux/phy/phy.h> Vladimir Oltean
2026-03-10  1:57   ` Claude review: " Claude Code Review Bot
2026-03-09 19:08 ` [PATCH v3 phy-next 13/24] phy: make phy_get_mode(), phy_(get|set)_bus_width() NULL tolerant Vladimir Oltean
2026-03-10  1:57   ` Claude review: " Claude Code Review Bot
2026-03-09 19:08 ` [PATCH v3 phy-next 14/24] phy: introduce phy_get_max_link_rate() helper for consumers Vladimir Oltean
2026-03-10  1:57   ` Claude review: " Claude Code Review Bot
2026-03-09 19:08 ` [PATCH v3 phy-next 15/24] drm/rockchip: dsi: include PHY provider header Vladimir Oltean
2026-03-10  1:57   ` Claude review: " Claude Code Review Bot
2026-03-09 19:08 ` [PATCH v3 phy-next 16/24] drm: bridge: cdns-mhdp8546: use consumer API for getting PHY bus width Vladimir Oltean
2026-03-10  1:57   ` Claude review: " Claude Code Review Bot
2026-03-09 19:08 ` [PATCH v3 phy-next 17/24] media: sunxi: a83-mips-csi2: include PHY provider header Vladimir Oltean
2026-03-10  1:57   ` Claude review: " Claude Code Review Bot
2026-03-09 19:08 ` [PATCH v3 phy-next 18/24] net: renesas: rswitch: " Vladimir Oltean
2026-03-10  1:57   ` Claude review: " Claude Code Review Bot
2026-03-09 19:08 ` [PATCH v3 phy-next 19/24] pinctrl: tegra-xusb: " Vladimir Oltean
2026-03-10  1:57   ` Claude review: " Claude Code Review Bot
2026-03-09 19:08 ` [PATCH v3 phy-next 20/24] power: supply: cpcap-charger: include missing <linux/property.h> Vladimir Oltean
2026-03-10  1:57   ` Claude review: " Claude Code Review Bot
2026-03-09 19:08 ` [PATCH v3 phy-next 21/24] phy: include PHY provider header (1/2) Vladimir Oltean
2026-03-09 19:08 ` [PATCH v3 phy-next 22/24] phy: include PHY provider header (2/2) Vladimir Oltean
2026-03-09 19:08 ` [PATCH v3 phy-next 23/24] phy: remove temporary provider compatibility from consumer header Vladimir Oltean
2026-03-10  1:57   ` Claude review: " Claude Code Review Bot
2026-03-09 19:08 ` [PATCH v3 phy-next 24/24] MAINTAINERS: add regexes for linux-phy Vladimir Oltean
2026-03-10  1:57   ` Claude review: " Claude Code Review Bot
2026-03-10  1:57 ` Claude review: Split Generic PHY consumer and provider API Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-19 22:32 [PATCH v5 phy-next 00/27] " Vladimir Oltean
2026-03-19 22:32 ` [PATCH v5 phy-next 11/27] drm/rockchip: dw_hdmi: avoid direct dereference of phy->dev.of_node Vladimir Oltean
2026-03-21 18:07   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch10-20260309190842.927634-11-vladimir.oltean@nxp.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox