From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/rockchip: dw_hdmi: avoid direct dereference of phy->dev.of_node
Date: Tue, 10 Mar 2026 11:57:16 +1000
Message-ID: <review-patch10-20260309190842.927634-11-vladimir.oltean@nxp.com>
In-Reply-To: <20260309190842.927634-11-vladimir.oltean@nxp.com>
References: <20260309190842.927634-1-vladimir.oltean@nxp.com> <20260309190842.927634-11-vladimir.oltean@nxp.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

Replaces `hdmi->phy->dev.of_node` with a DT phandle lookup to get the PHY's=
 OF node for clock provider resolution. The refactoring uses:
```c
index =3D of_property_match_string(np, "phy-names", "hdmi");
if (index >=3D 0) {
    if (!of_parse_phandle_with_args(np, "phys", "#phy-cells", index, &clksp=
ec)) {
        hdmi->hdmiphy_clk =3D of_clk_get_from_provider(&clkspec);
        of_node_put(clkspec.np);
```

This is a clean approach. The original code checked `if (hdmi->phy)` wherea=
s the new code checks `if (index >=3D 0)` =E2=80=94 these should be equival=
ent since `hdmi->phy` comes from the same DT property lookup. The `of_node_=
put(clkspec.np)` is correctly added (the original code via `hdmi->phy->dev.=
of_node` didn't need it since it was a borrowed reference). No issues.

---
Generated by Claude Code Patch Reviewer