From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gfs2: Prefer IS_ERR_OR_NULL over manual NULL check Date: Thu, 12 Mar 2026 07:27:18 +1000 Message-ID: In-Reply-To: <20260310-b4-is_err_or_null-v1-10-bd63b656022d@avm.de> References: <20260310-b4-is_err_or_null-v1-10-bd63b656022d@avm.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review These patches transform `while ((x =3D func()) && !IS_ERR(x))` into `while = (!IS_ERR_OR_NULL((x =3D func())))`. The transformation is functionally corr= ect but arguably less readable =E2=80=94 the assignment buried inside `IS_E= RR_OR_NULL()` is harder to spot. This is a style preference and not a bug. Example from net/sctp: ```c - while ((t =3D sctp_transport_get_next(net, iter)) && !IS_ERR(t)) { + while (!IS_ERR_OR_NULL((t =3D sctp_transport_get_next(net, iter)))) { ``` --- Generated by Claude Code Patch Reviewer