From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Pass struct drm_atomic_state* for analogix_dp_bridge_mode_set() Date: Tue, 10 Mar 2026 11:39:08 +1000 Message-ID: In-Reply-To: <20260310012458.169272-11-damon.ding@rock-chips.com> References: <20260310012458.169272-1-damon.ding@rock-chips.com> <20260310012458.169272-11-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Changes `analogix_dp_bridge_mode_set()` to take `struct drm_atomic_state*` and uses `drm_atomic_get_new_connector_for_encoder()` to find the connector instead of using the embedded `dp->connector`. This is the correct approach for bridge_connector compatibility. ```c connector = drm_atomic_get_new_connector_for_encoder(state, bridge->encoder); if (!connector) return; ``` The silent `return` on NULL connector is acceptable since mode_set is called during enable, and a connector should always exist at that point. Also lacks Reviewed-by tags. --- Generated by Claude Code Patch Reviewer