From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/dp: Use revision field of AS SDP data structure Date: Thu, 12 Mar 2026 06:55:30 +1000 Message-ID: In-Reply-To: <20260311113611.3393194-11-ankit.k.nautiyal@intel.com> References: <20260311113611.3393194-1-ankit.k.nautiyal@intel.com> <20260311113611.3393194-11-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Uses `as_sdp->revision` in pack/unpack instead of hardcoding `0x02`. Also adds revision to the comparison function and removes the HB2 == 0x02 validation check in unpack. **Concern about removing validation:** The unpack function previously rejected AS SDPs with HB2 != 0x02. Now it accepts any revision. While this enables version 1 support later (patch 18), removing the validation entirely means any garbage revision value will be silently accepted. Consider adding a range check (revision == 1 || revision == 2). --- Generated by Claude Code Patch Reviewer