From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: Use trace_invoke_##name() at guarded tracepoint call sites
Date: Fri, 13 Mar 2026 14:04:53 +1000 [thread overview]
Message-ID: <review-patch10-20260312150523.2054552-11-vineeth@bitbyteword.org> (raw)
In-Reply-To: <20260312150523.2054552-11-vineeth@bitbyteword.org>
Patch Review
Converts 6 call sites across 4 DRM files:
- **`amdgpu_cs.c:719`**: `trace_amdgpu_cs()` → `trace_invoke_amdgpu_cs()`. The guard is the early return at line 1001 (`if (!trace_amdgpu_cs_enabled()) return;`), which is a function-level guard in `trace_amdgpu_cs_ibs()`. ✓
- **`amdgpu_vm.c:1394`**: `trace_amdgpu_vm_bo_mapping()` → `trace_invoke_amdgpu_vm_bo_mapping()`, guarded by `trace_amdgpu_vm_bo_mapping_enabled()` ✓
- **`amdgpu_vm.c:2167`**: `trace_amdgpu_vm_bo_cs()` → `trace_invoke_amdgpu_vm_bo_cs()`. Looking at the upstream source, the function `amdgpu_vm_bo_trace_cs()` has a guard `if (!trace_amdgpu_vm_bo_cs_enabled()) return;` at the function entry. ✓
- **`amdgpu_dm.c:5190`**: `trace_amdgpu_dm_brightness()` → `trace_invoke_amdgpu_dm_brightness()`, guarded by `trace_amdgpu_dm_brightness_enabled()` ✓. Minor alignment change due to longer function name — looks fine.
- **`sched_entity.c:429`** and **`sched_entity.c:586`**: Both correctly guarded by their respective `_enabled()` checks. ✓
No issues with this patch.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-13 4:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 15:04 [PATCH 00/15] tracepoint: Avoid double static_branch evaluation at guarded call sites Vineeth Pillai (Google)
2026-03-12 15:04 ` [PATCH 01/15] tracepoint: Add trace_invoke_##name() API Vineeth Pillai (Google)
2026-03-12 15:12 ` Steven Rostedt
2026-03-12 15:39 ` Vineeth Remanan Pillai
2026-03-12 15:53 ` Peter Zijlstra
2026-03-12 16:05 ` Vineeth Remanan Pillai
2026-03-13 4:04 ` Claude review: " Claude Code Review Bot
2026-03-12 15:05 ` [PATCH 05/15] accel/habanalabs: Use trace_invoke_##name() at guarded tracepoint call sites Vineeth Pillai (Google)
2026-03-13 4:04 ` Claude review: " Claude Code Review Bot
2026-03-12 15:05 ` [PATCH 08/15] dma-buf: " Vineeth Pillai (Google)
2026-03-13 4:04 ` Claude review: " Claude Code Review Bot
2026-03-12 15:05 ` [PATCH 10/15] drm: " Vineeth Pillai (Google)
2026-03-13 4:04 ` Claude Code Review Bot [this message]
2026-03-12 15:12 ` [PATCH 00/15] tracepoint: Avoid double static_branch evaluation at guarded " Mathieu Desnoyers
2026-03-12 15:23 ` Steven Rostedt
2026-03-12 15:28 ` Mathieu Desnoyers
2026-03-12 15:40 ` Steven Rostedt
2026-03-12 15:49 ` Mathieu Desnoyers
2026-03-12 15:54 ` Peter Zijlstra
2026-03-12 15:57 ` Mathieu Desnoyers
2026-03-12 16:08 ` Vineeth Remanan Pillai
[not found] ` <CAEf4BzbnfyhCqp0ne=2gRnVxp-mdGmuZwDeFRyhRYH+eDcz2-w@mail.gmail.com>
2026-03-12 17:02 ` Steven Rostedt
2026-03-13 4:04 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch10-20260312150523.2054552-11-vineeth@bitbyteword.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox