From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: Use trace_invoke_##name() at guarded tracepoint call sites Date: Fri, 13 Mar 2026 14:04:53 +1000 Message-ID: In-Reply-To: <20260312150523.2054552-11-vineeth@bitbyteword.org> References: <1e3c2830-765e-4271-89f7-0b6784b37597@efficios.com> <20260312150523.2054552-11-vineeth@bitbyteword.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Converts 6 call sites across 4 DRM files: - **`amdgpu_cs.c:719`**: `trace_amdgpu_cs()` =E2=86=92 `trace_invoke_amdgpu= _cs()`. The guard is the early return at line 1001 (`if (!trace_amdgpu_cs_e= nabled()) return;`), which is a function-level guard in `trace_amdgpu_cs_ib= s()`. =E2=9C=93 - **`amdgpu_vm.c:1394`**: `trace_amdgpu_vm_bo_mapping()` =E2=86=92 `trace_i= nvoke_amdgpu_vm_bo_mapping()`, guarded by `trace_amdgpu_vm_bo_mapping_enabl= ed()` =E2=9C=93 - **`amdgpu_vm.c:2167`**: `trace_amdgpu_vm_bo_cs()` =E2=86=92 `trace_invoke= _amdgpu_vm_bo_cs()`. Looking at the upstream source, the function `amdgpu_v= m_bo_trace_cs()` has a guard `if (!trace_amdgpu_vm_bo_cs_enabled()) return;= ` at the function entry. =E2=9C=93 - **`amdgpu_dm.c:5190`**: `trace_amdgpu_dm_brightness()` =E2=86=92 `trace_i= nvoke_amdgpu_dm_brightness()`, guarded by `trace_amdgpu_dm_brightness_enabl= ed()` =E2=9C=93. Minor alignment change due to longer function name =E2=80= =94 looks fine. - **`sched_entity.c:429`** and **`sched_entity.c:586`**: Both correctly gua= rded by their respective `_enabled()` checks. =E2=9C=93 No issues with this patch. --- Generated by Claude Code Patch Reviewer