From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Pass vm_bind_op to vm_prepare_map_op_ctx Date: Sat, 14 Mar 2026 06:48:47 +1000 Message-ID: In-Reply-To: <20260313150956.1618635-11-adrian.larumbe@collabora.com> References: <20260313150956.1618635-1-adrian.larumbe@collabora.com> <20260313150956.1618635-11-adrian.larumbe@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean refactoring. The function signature is simplified by passing the whole `struct drm_panthor_vm_bind_op *op` instead of individual fields. The `panthor_vm_map_bo_range` caller constructs a temporary `drm_panthor_vm_bind_op` on the stack, which is reasonable. Minor nit: `struct drm_panthor_vm_bind_op op = {0};` followed by reassignment with a designated initializer is redundant -- the designated initializer is sufficient. --- Generated by Claude Code Patch Reviewer