From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/dp: clear EDID on display unplug
Date: Mon, 16 Mar 2026 12:12:57 +1000 [thread overview]
Message-ID: <review-patch10-20260314-hpd-refactor-v5-10-0c8450737d64@oss.qualcomm.com> (raw)
In-Reply-To: <20260314-hpd-refactor-v5-10-0c8450737d64@oss.qualcomm.com>
Patch Review
Adds `msm_dp_panel_unplugged()` to clear the EDID on unplug for non-eDP displays. Clean and correct — without this, stale EDID data would persist after unplug.
No issues.
---
**Summary of key concerns:**
- Patch 9 has the most issues: broken `get_modes()` logic, error handling regression in `plug_handle()` where `plugged = true` on failure, and pm_runtime ref stacking in `detect()`.
- Patch 7's IRQ handler default return value should be `IRQ_NONE`, not `IRQ_HANDLED`.
- The series would benefit from better locking documentation explaining the synchronization model that replaces `event_mutex`.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-16 2:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 1:09 [PATCH v5 00/10] drm/msm/dp: Drop the HPD state machine Dmitry Baryshkov
2026-03-14 1:09 ` [PATCH v5 01/10] drm/msm/dp: fix HPD state status bit shift value Dmitry Baryshkov
2026-03-16 2:12 ` Claude review: " Claude Code Review Bot
2026-03-14 1:09 ` [PATCH v5 02/10] drm/msm/dp: Fix the ISR_* enum values Dmitry Baryshkov
2026-03-16 2:12 ` Claude review: " Claude Code Review Bot
2026-03-14 1:09 ` [PATCH v5 03/10] drm/msm/dp: Read DPCD and sink count in bridge detect() Dmitry Baryshkov
2026-03-16 2:12 ` Claude review: " Claude Code Review Bot
2026-03-14 1:09 ` [PATCH v5 04/10] drm/msm/dp: Move link training to atomic_enable() Dmitry Baryshkov
2026-03-16 2:12 ` Claude review: " Claude Code Review Bot
2026-03-14 1:09 ` [PATCH v5 05/10] drm/msm/dp: Drop EV_USER_NOTIFICATION Dmitry Baryshkov
2026-03-16 2:12 ` Claude review: " Claude Code Review Bot
2026-03-14 1:09 ` [PATCH v5 06/10] drm/msm/dp: drop event data Dmitry Baryshkov
2026-03-16 2:12 ` Claude review: " Claude Code Review Bot
2026-03-14 1:09 ` [PATCH v5 07/10] drm/msm/dp: rework HPD handling Dmitry Baryshkov
2026-03-16 2:12 ` Claude review: " Claude Code Review Bot
2026-03-14 1:09 ` [PATCH v5 08/10] drm/msm/dp: Add sink_count to debug logs Dmitry Baryshkov
2026-03-16 2:12 ` Claude review: " Claude Code Review Bot
2026-03-14 1:09 ` [PATCH v5 09/10] drm/msm/dp: turn link_ready into plugged Dmitry Baryshkov
2026-03-16 2:12 ` Claude review: " Claude Code Review Bot
2026-03-14 1:09 ` [PATCH v5 10/10] drm/msm/dp: clear EDID on display unplug Dmitry Baryshkov
2026-03-16 2:12 ` Claude Code Review Bot [this message]
2026-03-15 0:51 ` [PATCH v5 00/10] drm/msm/dp: Drop the HPD state machine Val Packett
2026-03-15 1:10 ` Val Packett
2026-03-16 2:12 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch10-20260314-hpd-refactor-v5-10-0c8450737d64@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox