From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dp: clear EDID on display unplug Date: Mon, 16 Mar 2026 12:12:57 +1000 Message-ID: In-Reply-To: <20260314-hpd-refactor-v5-10-0c8450737d64@oss.qualcomm.com> References: <20260314-hpd-refactor-v5-0-0c8450737d64@oss.qualcomm.com> <20260314-hpd-refactor-v5-10-0c8450737d64@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Adds `msm_dp_panel_unplugged()` to clear the EDID on unplug for non-eDP dis= plays. Clean and correct =E2=80=94 without this, stale EDID data would pers= ist after unplug. No issues. --- **Summary of key concerns:** - Patch 9 has the most issues: broken `get_modes()` logic, error handling r= egression in `plug_handle()` where `plugged =3D true` on failure, and pm_ru= ntime ref stacking in `detect()`. - Patch 7's IRQ handler default return value should be `IRQ_NONE`, not `IRQ= _HANDLED`. - The series would benefit from better locking documentation explaining the= synchronization model that replaces `event_mutex`. --- Generated by Claude Code Patch Reviewer