From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Pass struct drm_atomic_state* for analogix_dp_bridge_mode_set() Date: Sun, 22 Mar 2026 04:35:47 +1000 Message-ID: In-Reply-To: <20260319071452.1961274-11-damon.ding@rock-chips.com> References: <20260319071452.1961274-1-damon.ding@rock-chips.com> <20260319071452.1961274-11-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Gets the connector from atomic state instead of the now-removed `dp->connector` field. The early return when `connector` is NULL is a safe fallback. Note: The `old_state` variable name for `struct drm_atomic_state *` passed from `bridge_atomic_enable` is potentially confusing since this is actually the full atomic state (not just "old" state), but this naming is consistent with how other DRM bridge drivers use it. No issues. --- Generated by Claude Code Patch Reviewer