From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/crtc: Add new atomic_create_state callback Date: Sun, 22 Mar 2026 03:32:27 +1000 Message-ID: In-Reply-To: <20260320-drm-mode-config-init-v2-10-c63f1134e76c@kernel.org> References: <20260320-drm-mode-config-init-v2-0-c63f1134e76c@kernel.org> <20260320-drm-mode-config-init-v2-10-c63f1134e76c@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Same pattern as patch 8 but for CRTCs. The `__drm_atomic_helper_crtc_create_state()` wrapper here does have added value: it calls `drm_crtc_vblank_reset()` in addition to `__drm_atomic_helper_crtc_state_init()`, mirroring what `__drm_atomic_helper_crtc_reset()` does. Minor typo in the commit message: "software tate" should be "software state". Same silent error discard issue in `drm_mode_config_reset()` as noted for patch 8. --- Generated by Claude Code Patch Reviewer