From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: Use trace_call__##name() at guarded tracepoint call sites
Date: Wed, 25 Mar 2026 07:48:31 +1000 [thread overview]
Message-ID: <review-patch10-20260323160052.17528-11-vineeth@bitbyteword.org> (raw)
In-Reply-To: <20260323160052.17528-11-vineeth@bitbyteword.org>
Patch Review
All four conversions are correct:
- `amdgpu_cs.c`: `trace_amdgpu_cs_ibs()` is a helper that is only called from within a `trace_amdgpu_cs_enabled()` guard (verified in the existing tree at `amdgpu_cs.c:1021`), so using `trace_call__amdgpu_cs()` inside the loop is correct.
- `amdgpu_vm.c:1394`: Guarded by `trace_amdgpu_vm_bo_mapping_enabled()` — correct.
- `amdgpu_vm.c:2177`: The function `amdgpu_vm_bo_trace_cs()` has an early return `if (!trace_amdgpu_vm_bo_cs_enabled()) return;` — correct.
- `amdgpu_dm.c`: Guarded by `trace_amdgpu_dm_brightness_enabled()` — correct.
- `sched_entity.c:429`: Guarded by `trace_drm_sched_job_unschedulable_enabled()` — correct.
- `sched_entity.c:586`: The `trace_drm_sched_job_add_dep_enabled()` guard is implicit via the xa_for_each being inside the enabled check — verified correct from the patch context.
No issues with any of the conversions.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-24 21:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 16:00 [PATCH v2 00/19] tracepoint: Avoid double static_branch evaluation at guarded call sites Vineeth Pillai (Google)
2026-03-23 16:00 ` [PATCH v2 01/19] tracepoint: Add trace_call__##name() API Vineeth Pillai (Google)
2026-03-24 21:48 ` Claude review: " Claude Code Review Bot
2026-03-23 16:00 ` [PATCH v2 05/19] accel/habanalabs: Use trace_call__##name() at guarded tracepoint call sites Vineeth Pillai (Google)
2026-03-24 21:48 ` Claude review: " Claude Code Review Bot
2026-03-23 16:00 ` [PATCH v2 08/19] dma-buf: " Vineeth Pillai (Google)
2026-03-24 21:48 ` Claude review: " Claude Code Review Bot
2026-03-23 16:00 ` [PATCH v2 10/19] drm: " Vineeth Pillai (Google)
2026-03-24 21:48 ` Claude Code Review Bot [this message]
2026-03-24 14:28 ` [PATCH v2 00/19] tracepoint: Avoid double static_branch evaluation at guarded " Steven Rostedt
2026-03-24 21:48 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch10-20260323160052.17528-11-vineeth@bitbyteword.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox