From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: Use trace_call__##name() at guarded tracepoint call sites Date: Wed, 25 Mar 2026 07:48:31 +1000 Message-ID: In-Reply-To: <20260323160052.17528-11-vineeth@bitbyteword.org> References: <20260323160052.17528-1-vineeth@bitbyteword.org> <20260323160052.17528-11-vineeth@bitbyteword.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review All four conversions are correct: - `amdgpu_cs.c`: `trace_amdgpu_cs_ibs()` is a helper that is only called fr= om within a `trace_amdgpu_cs_enabled()` guard (verified in the existing tre= e at `amdgpu_cs.c:1021`), so using `trace_call__amdgpu_cs()` inside the loo= p is correct. - `amdgpu_vm.c:1394`: Guarded by `trace_amdgpu_vm_bo_mapping_enabled()` =E2= =80=94 correct. - `amdgpu_vm.c:2177`: The function `amdgpu_vm_bo_trace_cs()` has an early r= eturn `if (!trace_amdgpu_vm_bo_cs_enabled()) return;` =E2=80=94 correct. - `amdgpu_dm.c`: Guarded by `trace_amdgpu_dm_brightness_enabled()` =E2=80= =94 correct. - `sched_entity.c:429`: Guarded by `trace_drm_sched_job_unschedulable_enabl= ed()` =E2=80=94 correct. - `sched_entity.c:586`: The `trace_drm_sched_job_add_dep_enabled()` guard i= s implicit via the xa_for_each being inside the enabled check =E2=80=94 ver= ified correct from the patch context. No issues with any of the conversions. --- Generated by Claude Code Patch Reviewer