From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/mxsfb/lcdif: use DRM_BRIDGE_ATTACH_NO_CONNECTOR and the bridge-connector Date: Tue, 31 Mar 2026 16:54:45 +1000 Message-ID: In-Reply-To: <20260330-drm-lcdif-dbanc-v2-10-c7f2af536a24@bootlin.com> References: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> <20260330-drm-lcdif-dbanc-v2-10-c7f2af536a24@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The final conversion. The diff is clean: ```c ret = drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR); // ... then: connector = drm_bridge_connector_init(lcdif->drm, encoder); // ... then: ret = drm_connector_attach_encoder(connector, encoder); ``` This follows the standard `DRM_BRIDGE_ATTACH_NO_CONNECTOR` pattern correctly. The Kconfig additions (`DRM_DISPLAY_HELPER`, `DRM_BRIDGE_CONNECTOR`) are the right dependencies. **Summary of actionable items:** 1. **Patch 8:** Remove the unused `hdmi_conn` variable 2. **Patch 8:** Fix typos in commit message ("device tre", "isntantiating", "abd") 3. **Patch 7:** Maintainers should verify that `drm_bridge_attach` takes a reference, so that `__free(drm_bridge_put)` on `next_bridge` is safe --- Generated by Claude Code Patch Reviewer