From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/dp: Use revision field of AS SDP data structure Date: Tue, 31 Mar 2026 17:39:47 +1000 Message-ID: In-Reply-To: <20260330040656.4116502-11-ankit.k.nautiyal@intel.com> References: <20260330040656.4116502-1-ankit.k.nautiyal@intel.com> <20260330040656.4116502-11-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Uses `as_sdp->revision` instead of hardcoded `0x02` for pack/unpack. Also r= emoves the HB2 validation check in unpack. Has Ville's R-b. Minor concern: removing the `HB2 !=3D 0x02` check in unpack means the drive= r will now accept any revision, but `revision` is stored and compared in pa= tch 11. This is fine =E2=80=94 it's more flexible. --- Generated by Claude Code Patch Reviewer