From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbcon: Put font-rotation state into separate struct Date: Sun, 12 Apr 2026 13:55:03 +1000 Message-ID: In-Reply-To: <20260407092555.58816-11-tzimmermann@suse.de> References: <20260407092555.58816-1-tzimmermann@suse.de> <20260407092555.58816-11-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Verdict: Good organization.** Moves all rotation-related state into a nested `struct rotated` inside `fbcon_par`, guarded by `CONFIG_FRAMEBUFFER_CONSOLE_ROTATION`. This cleanly separates rotation concerns from core fbcon state and avoids allocating unused fields when rotation is disabled. The field rename `fontdata` to `rotated.fontdata` (now typed as `font_data_t *`) and comparison change from `vc->vc_font.data` to `par->p->fontdata` is consistent with the prerequisite series's introduction of `font_data_t`. The rotation comparison change from `par->p->con_rotate` to `par->rotate` is semantically correct (checking the par's own rotation value against what was cached). The `#ifdef` guards around `kfree(par->rotated.buf)` in `fbcon_release` and initialization in `fbcon_startup` are necessary and correct. No issues. --- **Summary**: The series is well-crafted overall but **patch 7 has a bug in `__font_glyph_rotate_180`** that will corrupt 180-degree rotation for fonts with non-byte-aligned widths. This needs to be fixed. All other patches look correct. --- Generated by Claude Code Patch Reviewer