From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/dp: Account for AS_SDP guardband only when enabled Date: Sun, 12 Apr 2026 12:51:27 +1000 Message-ID: In-Reply-To: <20260408084239.1295325-11-ankit.k.nautiyal@intel.com> References: <20260408084239.1295325-1-ankit.k.nautiyal@intel.com> <20260408084239.1295325-11-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **R-b: Ville Syrjala** Removes the `assume_all_enabled && HAS_AS_SDP(display)` path from the AS SDP guardband calculation, now only considering AS SDP if it's actually enabled in `crtc_state->infoframes.enable`. This drops the `struct intel_display *display` variable entirely since it's no longer needed. The logic change means that when `assume_all_enabled` is true (used during guardband precomputation), AS SDP is no longer speculatively accounted for. This is intentional -- later patches (26) ensure AS SDP is always enabled when it could be needed. However, there's a sequencing concern: between this patch and patch 26, the guardband might be underestimated for configurations that have AS SDP capability but haven't yet enabled it. In a bisection between patches 10 and 26, this could theoretically cause problems. Worth noting but likely acceptable given the series is intended to land as a unit. --- Generated by Claude Code Patch Reviewer