From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Pass struct drm_atomic_state* for analogix_dp_bridge_mode_set() Date: Sun, 12 Apr 2026 11:37:41 +1000 Message-ID: In-Reply-To: <20260409065301.446670-11-damon.ding@rock-chips.com> References: <20260409065301.446670-1-damon.ding@rock-chips.com> <20260409065301.446670-11-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `struct drm_atomic_state *state` parameter to `analogix_dp_bridge_mode_set()` and uses `drm_atomic_get_new_connector_for_encoder()` to obtain the connector, replacing the direct `dp->connector.display_info` access. This is necessary preparation for removing the private connector in patch 11. The `connector` NULL check with early return is appropriate - if no connector is found, silently returning is safe since the bridge isn't connected. No issues. --- Generated by Claude Code Patch Reviewer