From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: himax-hx8394: support Waveshare DSI panels Date: Sun, 12 Apr 2026 09:06:55 +1000 Message-ID: In-Reply-To: <20260411-waveshare-dsi-touch-v2-10-75cdbeac5156@oss.qualcomm.com> References: <20260411-waveshare-dsi-touch-v2-0-75cdbeac5156@oss.qualcomm.com> <20260411-waveshare-dsi-touch-v2-10-75cdbeac5156@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds Waveshare 5.0" and 5.5" HX8394-F panels. 1. **Minor**: Trailing semicolons after both init function bodies (`waveshare_5_0_inch_a_init_sequence` and `waveshare_5_5_inch_a_init_sequence`). 2. **Suspicious**: Both panels declare identical physical dimensions `width_mm = 62, height_mm = 110`. The diagonal works out to ~5.0", so the 5.5" panel dimensions are likely wrong. --- --- Generated by Claude Code Patch Reviewer