From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: vbios: construct `FwSecBiosImage` directly from BIOS images Date: Thu, 23 Apr 2026 08:42:25 +1000 Message-ID: In-Reply-To: <20260421-fix-vbios-v3-10-8f648aef7a85@nvidia.com> References: <20260421-fix-vbios-v3-0-8f648aef7a85@nvidia.com> <20260421-fix-vbios-v3-10-8f648aef7a85@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Good refactoring. `FwSecBiosBuilder` is removed entirely. The new `FwSecBiosImage::new()` constructor takes ownership of the PCI-AT and both FWSEC `BiosImage`s, does the falcon data setup inline, and returns a fully-constructed `FwSecBiosImage`. This is a clean builder-pattern removal. The debug-assertion block for printing the desc header is moved from `build()` to the call site in `Vbios::new()`, which is appropriate. No issues. --- Generated by Claude Code Patch Reviewer