From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: dw_hdmi: Use dw_hdmi_connector_status_update() Date: Tue, 05 May 2026 07:58:56 +1000 Message-ID: In-Reply-To: <20260504191059.275928-11-jonas@kwiboo.se> References: <20260504191059.275928-1-jonas@kwiboo.se> <20260504191059.275928-11-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Moves EDID refresh from `get_modes` to `detect` and `force` callbacks. This aligns the dw-hdmi connector behavior with the bridge connector pattern where EDID is read during detection, not during mode enumeration. ```c static int dw_hdmi_connector_get_modes(struct drm_connector *connector) { - dw_hdmi_connector_status_update(connector, connector->status); return drm_edid_connector_add_modes(connector); } ``` The status_update helper now correctly invalidates EDID/CEC on disconnect and only sets CEC phys addr on connect. Has Reviewed-by. --- Generated by Claude Code Patch Reviewer