From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: Convert submit helpers to operate on struct v3d_submit Date: Sat, 16 May 2026 15:59:29 +1000 Message-ID: In-Reply-To: <20260510-v3d-sched-misc-fixes-v2-10-ca4aba343ef6@igalia.com> References: <20260510-v3d-sched-misc-fixes-v2-0-ca4aba343ef6@igalia.com> <20260510-v3d-sched-misc-fixes-v2-10-ca4aba343ef6@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Large patch that generalizes the helper functions. Key changes: 1. `v3d_submit_lock_reservations()` iterates all jobs and locks the union o= f BOs under one `drm_exec` with `DRM_EXEC_IGNORE_DUPLICATES`. 2. `v3d_attach_fences_and_unlock_reservation()` attaches the *last* job's f= ence to all BOs across all jobs. 3. `v3d_lookup_bos()` now takes `struct v3d_submit` and operates on the las= t job. The CPU ioctl uses two `struct v3d_submit` instances (`submit` and `indirec= t_submit`) =E2=80=94 a transitional state cleaned up in patch 11. The `v3d_job_allocate()`, `v3d_job_deallocate()`, and `v3d_job_init()` func= tions are removed since `v3d_submit_add_job()` subsumes them. Good cleanup. No issues. --- Generated by Claude Code Patch Reviewer