From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vmwgfx: Remove unused field struct vmwgfx_du_update_plane.old_state Date: Sat, 16 May 2026 15:34:46 +1000 Message-ID: In-Reply-To: <20260511122421.114014-11-tzimmermann@suse.de> References: <20260511122421.114014-1-tzimmermann@suse.de> <20260511122421.114014-11-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Correctness**: Clean removal of the now-unused `old_state` field from `struct vmw_du_update_plane`. All callers (`vmw_sou_plane_update_bo`, `vmw_sou_plane_update_surface`, `vmw_stdu_plane_update_bo`, `vmw_stdu_plane_update_surface`) are updated to remove the `old_state` parameter and its assignment. The `vmw_stdu_primary_plane_atomic_update` function also no longer fetches the old plane state. All correct. --- **Summary**: The series is well-designed and addresses a real consistency problem. The main actionable item is the error path leak in patch 5 (appletbdrm `begin_fb_access`). Everything else is clean. --- Generated by Claude Code Patch Reviewer