From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: media: renesas: vsp1: Declare index variables in for loop statement Date: Sat, 16 May 2026 14:29:50 +1000 Message-ID: In-Reply-To: <20260511235637.3468558-11-laurent.pinchart+renesas@ideasonboard.com> References: <20260511235637.3468558-1-laurent.pinchart+renesas@ideasonboard.com> <20260511235637.3468558-11-laurent.pinchart+renesas@ideasonboard.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Mechanical change moving `unsigned int i` (and similar) declarations from f= unction scope into `for` loop statements across 12 files. This prevents acc= idental use of loop indices after the loop =E2=80=94 a good defensive codin= g practice. One small stylistic addition: in `vsp1_hgt.c`, braces are added around the = outer `for` when nesting two for-loops: ```c for (unsigned int m =3D 0; m < 6; ++m) { for (unsigned int n =3D 0; n < 32; ++n) *data++ =3D vsp1_hgt_read(hgt, VI6_HGT_HISTO(m, n)); } ``` This is good =E2=80=94 it's required by checkpatch/coding style when the in= ner statement is itself a loop. **All correct. No functional change.** --- Generated by Claude Code Patch Reviewer