From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/plane: Add new atomic_create_state callback Date: Sat, 16 May 2026 13:22:54 +1000 Message-ID: In-Reply-To: <20260512-drm-mode-config-init-v4-10-591dfdcc1bf9@kernel.org> References: <20260512-drm-mode-config-init-v4-0-591dfdcc1bf9@kernel.org> <20260512-drm-mode-config-init-v4-10-591dfdcc1bf9@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Adds `atomic_create_state` to `drm_plane_funcs`, the helper `drm_atomic_hel= per_plane_create_state()`, and the fallback logic in `drm_mode_config_reset= ()`: ```c drm_for_each_plane(plane, dev) { if (plane->funcs->reset) plane->funcs->reset(plane); else if (plane->funcs->atomic_create_state) drm_mode_config_plane_reset_with_create_state(plane); } ``` The `drm_mode_config_plane_reset_with_create_state()` function properly des= troys existing state before creating new. The `drm_mode_config_reset()` ret= urn type is `void`, so errors from `drm_mode_config_plane_reset_with_create= _state()` are silently dropped =E2=80=94 this matches the existing non-fall= ible `reset()` pattern and is acceptable for the reset path. No issues. --- Generated by Claude Code Patch Reviewer