public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/rockchip: analogix_dp: Add support for RK3576
Date: Mon, 25 May 2026 20:40:14 +1000	[thread overview]
Message-ID: <review-patch10-20260521080835.1362416-11-damon.ding@rock-chips.com> (raw)
In-Reply-To: <20260521080835.1362416-11-damon.ding@rock-chips.com>

Patch Review

```c
+static const struct rockchip_dp_chip_data rk3576_edp[] = {
+	{
+		.chip_type = RK3576_EDP,
+		.reg = 0x27dc0000,
+	},
+	{ /* sentinel */ }
+};
```

**Question/concern**: The RK3576 chip data does not set `edp_mode`, unlike RK3588 which has `.edp_mode = GRF_REG_FIELD(0x0000, 0, 0)`. This is *functionally safe* — `rockchip_grf_field_write()` checks `!field->valid` and returns 0 for unset fields (line 107 in `analogix_dp-rockchip.c`). However, the commit message states RK3576 "fully match[es] the proven RK3588 design." If the hardware really does match RK3588, does RK3576 not have an eDP mode selection bit in its VO0 GRF? If it does, it should be populated here. If it genuinely doesn't need one, a brief comment or commit message note explaining why would be helpful.

**Also**: The single-entry array (vs RK3588's two entries) correctly reflects that RK3576 has only one eDP controller.

The DT match table addition maintains alphabetical ordering:

```c
+	{.compatible = "rockchip,rk3576-edp", .data = &rk3576_edp },
```

Overall this patch is fine, but the missing `edp_mode` relative to RK3588 deserves confirmation from the author.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-25 10:40 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21  8:08 [PATCH v6 00/10] Add eDP support for RK3576 Damon Ding
2026-05-21  8:08 ` [PATCH v6 01/10] dt-bindings: display: rockchip: analogix-dp: Fix hclk as third clock for RK3588 Damon Ding
2026-05-21 19:54   ` Conor Dooley
2026-05-22  3:02     ` Damon Ding
2026-05-22  6:11   ` Krzysztof Kozlowski
2026-05-22  6:29     ` Damon Ding
2026-05-25 10:40   ` Claude review: " Claude Code Review Bot
2026-05-21  8:08 ` [PATCH v6 02/10] dt-bindings: display: rockchip: analogix-dp: Add per-clock descriptions Damon Ding
2026-05-25 10:40   ` Claude review: " Claude Code Review Bot
2026-05-21  8:08 ` [PATCH v6 03/10] arm64: dts: rockchip: Add missing hclk for RK3588 eDP0 Damon Ding
2026-05-25 10:40   ` Claude review: " Claude Code Review Bot
2026-05-21  8:08 ` [PATCH v6 04/10] arm64: dts: rockchip: Add missing hclk for RK3588 eDP1 Damon Ding
2026-05-25 10:40   ` Claude review: " Claude Code Review Bot
2026-05-21  8:08 ` [PATCH v6 05/10] drm/rockchip: analogix_dp: Enable hclk for RK3588 Damon Ding
2026-05-25 10:40   ` Claude review: " Claude Code Review Bot
2026-05-21  8:08 ` [PATCH v6 06/10] dt-bindings: display: rockchip: analogix-dp: Add support for RK3576 Damon Ding
2026-05-25 10:40   ` Claude review: " Claude Code Review Bot
2026-05-21  8:08 ` [PATCH v6 07/10] arm64: dts: rockchip: Add eDP node " Damon Ding
2026-05-25 10:40   ` Claude review: " Claude Code Review Bot
2026-05-21  8:08 ` [PATCH v6 08/10] drm/bridge: analogix_dp: Rename and simplify is_rockchip() Damon Ding
2026-05-25 10:40   ` Claude review: " Claude Code Review Bot
2026-05-21  8:08 ` [PATCH v6 09/10] drm/bridge: analogix_dp: Add support for RK3576 Damon Ding
2026-05-25 10:40   ` Claude review: " Claude Code Review Bot
2026-05-21  8:08 ` [PATCH v6 10/10] drm/rockchip: " Damon Ding
2026-05-25 10:40   ` Claude Code Review Bot [this message]
2026-05-25 10:40 ` Claude review: Add eDP " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-27  2:43 [PATCH v9 00/10] " Damon Ding
2026-05-27  2:43 ` [PATCH v9 10/10] drm/rockchip: analogix_dp: Add " Damon Ding
2026-05-27  3:55   ` Claude review: " Claude Code Review Bot
2026-05-25 12:53 [PATCH v8 00/10] Add eDP " Damon Ding
2026-05-25 12:53 ` [PATCH v8 10/10] drm/rockchip: analogix_dp: Add " Damon Ding
2026-05-25 21:12   ` Claude review: " Claude Code Review Bot
2026-05-25  8:20 [PATCH v7 00/10] Add eDP " Damon Ding
2026-05-25  8:20 ` [PATCH v7 10/10] drm/rockchip: analogix_dp: Add " Damon Ding
2026-05-25 21:34   ` Claude review: " Claude Code Review Bot
2026-05-13  7:44 [PATCH v5 00/10] Add eDP " Damon Ding
2026-05-13  7:44 ` [PATCH v5 10/10] drm/rockchip: analogix_dp: Add " Damon Ding
2026-05-16  2:26   ` Claude review: " Claude Code Review Bot
2026-03-19 10:40 [PATCH v2 0/9] Add eDP " Damon Ding
2026-03-20  0:45 ` [PATCH v2 9/9] drm/rockchip: analogix_dp: Add " Damon Ding
2026-03-21 18:26   ` Claude review: " Claude Code Review Bot
2026-03-10 10:53 [PATCH v1 0/4] Add eDP " Damon Ding
2026-03-10 10:53 ` [PATCH v1 4/4] drm/rockchip: analogix_dp: Add " Damon Ding
2026-03-11  3:27   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch10-20260521080835.1362416-11-damon.ding@rock-chips.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox