From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: ti: k3-am62-verdin: Add Toradex OV5640 CSI Cameras Date: Mon, 25 May 2026 19:56:40 +1000 Message-ID: In-Reply-To: <20260521150038.103538-27-ivitro@gmail.com> References: <20260521150038.103538-17-ivitro@gmail.com> <20260521150038.103538-27-ivitro@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Good factoring with common code in `k3-am625-verdin-ov5640.dtsi` and two th= in overlays for 24MHz and 27MHz clock variants. **Missing `regulator-min-microvolt` / `regulator-max-microvolt`** in the `r= egulator-camera` fixed regulator node. While optional for `regulator-fixed`= , some DT validators may warn. Consider adding these. **The `clk_ov5640_osc` fixed-clock node** is created without `clock-frequen= cy` =E2=80=94 it's set by each overlay. This is a clean pattern. The camera node at `&main_i2c3` address `0x3c` is correct for OV5640. Suppl= y names `AVDD`, `DOVDD`, `DVDD` all point to the same regulator, which is a= common pattern when a single power rail feeds all camera supplies through = the connector. --- Generated by Claude Code Patch Reviewer