From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dp: clear EDID on display unplug Date: Mon, 25 May 2026 17:13:09 +1000 Message-ID: In-Reply-To: <20260524-hpd-refactor-v6-10-cf3ab488dd7b@oss.qualcomm.com> References: <20260524-hpd-refactor-v6-0-cf3ab488dd7b@oss.qualcomm.com> <20260524-hpd-refactor-v6-10-cf3ab488dd7b@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `msm_dp_panel_unplugged()` to clear the EDID on display unplug, correctly guarded by `!is_edp`. ```c +void msm_dp_panel_unplugged(struct msm_dp_panel *msm_dp_panel, + struct drm_connector *connector) +{ + drm_edid_connector_update(connector, NULL); + drm_edid_free(msm_dp_panel->drm_edid); + msm_dp_panel->drm_edid = NULL; +} ``` **No issues.** Clean and correct. --- **Summary of items requiring attention:** 1. **Patch 9 (get_modes):** Logic bug - "No sink connected" printed on success path 2. **Patch 9 (detect):** PM refcount leak when device is plugged 3. **Patch 9 (plug_handle):** Missing early-out for already-plugged state 4. **Patch 7 (IRQ thread):** REPLUG interrupt potentially unhandled in internal HPD path 5. **Patch 4:** C++ style comment 6. **Patch 3:** Redundant variable assignment 7. **Patch 9:** Two typos in comments/kerneldoc --- Generated by Claude Code Patch Reviewer