From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: analogix_dp: Add support for RK3576 Date: Wed, 27 May 2026 13:55:47 +1000 Message-ID: In-Reply-To: <20260527024336.191433-11-damon.ding@rock-chips.com> References: <20260527024336.191433-1-damon.ding@rock-chips.com> <20260527024336.191433-11-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Adds the chip_data and OF match entry: ```c +static const struct rockchip_dp_chip_data rk3576_edp[] =3D { + { + .chip_type =3D RK3576_EDP, + .reg =3D 0x27dc0000, + }, + { /* sentinel */ } +}; ``` **Design observation:** Unlike `rk3588_edp` which has `.edp_mode =3D GRF_RE= G_FIELD(0x0000, 0, 0)`, the RK3576 data has no `edp_mode` field. This means= `rockchip_dp_poweron()` at line 147 (`rockchip_grf_field_write(dp->grf, &d= p->data->edp_mode, 1)`) will be a no-op since `.valid` defaults to `false`.= Similarly, no `lcdc_sel` field, so the VOP output selection in `rockchip_d= p_drm_encoder_enable()` is also a no-op. This is presumably intentional for= RK3576 hardware =E2=80=94 perhaps the eDP mode is always-on or configured = elsewhere, and there's only one VOP path. Given this is v9 with hardware te= sting, this appears correct. No blocking issues. --- Generated by Claude Code Patch Reviewer