From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tidss: Add support for DPIENABLE bit Date: Thu, 04 Jun 2026 16:54:12 +1000 Message-ID: In-Reply-To: <20260529-beagley-ai-display-v3-10-7fefdc5d1adf@ideasonboard.com> References: <20260529-beagley-ai-display-v3-0-7fefdc5d1adf@ideasonboard.com> <20260529-beagley-ai-display-v3-10-7fefdc5d1adf@ideasonboard.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Adds `has_vp_control_dpienable` feature flag and manages the VP_CONTROL.DPI= ENABLE bit. The bit is disabled for all VPs at init (resume), then enabled/= disabled in prepare/unprepare for DPI outputs only. **Minor style:** `GENMASK(6, 6)` for a single bit =E2=80=94 `BIT(6)` would = be more conventional, but the existing code uses `GENMASK` for other single= bits too (`GENMASK(5, 5)`, `GENMASK(0, 0)`), so this is consistent. No functional issues found. --- Generated by Claude Code Patch Reviewer