From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vmwgfx: Remove unused field struct vmwgfx_du_update_plane.old_state Date: Thu, 04 Jun 2026 15:21:22 +1000 Message-ID: In-Reply-To: <20260530185716.65688-11-tzimmermann@suse.de> References: <20260530185716.65688-1-tzimmermann@suse.de> <20260530185716.65688-11-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Removes `old_state` from `struct vmw_du_update_plane` and all assignments to it in vmwgfx_scrn.c and vmwgfx_stdu.c. Also removes `old_state` parameter from `vmw_sou_plane_update_bo()`, `vmw_sou_plane_update_surface()`, `vmw_stdu_plane_update_bo()`, and `vmw_stdu_plane_update_surface()`, and cleans up their callers. **No issues.** Clean final cleanup patch. --- **Summary:** The series is well-designed, addresses real problems with damage handling ordering, and is carefully sequenced. The only concern is a narrow bisectability window between patches 4 and 6 where appletbdrm passes NULL for `old_state` while `damage_iter_init` still dereferences it for src-coordinate comparisons. In practice this is very unlikely to be hit (Touch Bar + fixed src coords + short-circuit evaluation), but it's worth noting. The series has appropriate acks and is ready for merge. --- Generated by Claude Code Patch Reviewer