From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: auto-link panel backlight in bridge connector Date: Thu, 04 Jun 2026 14:54:32 +1000 Message-ID: In-Reply-To: <20260531114908.1693426-11-superm1@kernel.org> References: <20260531114908.1693426-1-superm1@kernel.org> <20260531114908.1693426-11-superm1@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Looks good** Clean integration. The `drm_panel_bridge_to_panel` helper is properly guard= ed. Linking happens during `drm_bridge_connector_init` which is the right t= ime. One question: if `drm_backlight_alloc` succeeds but `panel->backlight` is N= ULL (panel has no backlight), the connector gets a backlight property with = 0-0 range permanently. Is that the desired behavior? It means every panel b= ridge connector will have a LUMINANCE property even if no backlight exists. Wait, looking more carefully =E2=80=94 the alloc only happens if `panel && = panel->backlight`: ```c + if (panel && panel->backlight) { + ret =3D drm_backlight_alloc(connector); ``` This is correct. --- Generated by Claude Code Patch Reviewer