From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/display: bridge_connector: Switch to .detect_ctx() connector helper Date: Thu, 04 Jun 2026 13:33:48 +1000 Message-ID: In-Reply-To: <20260602-dw-hdmi-qp-scramb-v7-10-445eb54ee1ed@collabora.com> References: <20260602-dw-hdmi-qp-scramb-v7-0-445eb54ee1ed@collabora.com> <20260602-dw-hdmi-qp-scramb-v7-10-445eb54ee1ed@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Potential issue:** Errors from `drm_atomic_helper_connector_hdmi_hotplug_= ctx()` other than `-EDEADLK` are silently swallowed: ```c if (hdmi) { ret =3D drm_atomic_helper_connector_hdmi_hotplug_ctx(connector, status, ctx); if (ret =3D=3D -EDEADLK) return ret; } ``` If `drm_scdc_sync_status()` fails (e.g., I2C error during CRTC reset), the = error is lost and the function returns `status` as if nothing happened. Thi= s is likely intentional =E2=80=94 detect should report connector status eve= n if SCDC recovery failed =E2=80=94 but a `drm_dbg_kms()` for non-EDEADLK e= rrors would help debugging. --- Generated by Claude Code Patch Reviewer