From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: Convert submit helpers to operate on struct v3d_submit Date: Thu, 04 Jun 2026 11:24:42 +1000 Message-ID: In-Reply-To: <20260603-v3d-sched-misc-fixes-v3-10-d7114bba55a0@igalia.com> References: <20260603-v3d-sched-misc-fixes-v3-0-d7114bba55a0@igalia.com> <20260603-v3d-sched-misc-fixes-v3-10-d7114bba55a0@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Large refactoring that generalizes the lock/fence/lookup helpers to operate on the full `struct v3d_submit`. Key changes: - `v3d_submit_lock_reservations()` now iterates all jobs and locks the union of BOs under `DRM_EXEC_IGNORE_DUPLICATES`. The `drm_exec_retry_on_contention()` is correctly placed inside the `drm_exec_until_all_locked()` loop. - `v3d_lookup_bos()` now takes `struct v3d_submit *` and always attaches BOs to the last job. - `v3d_attach_fences_and_unlock_reservation()` walks all jobs and attaches the chain's last fence to every BO. - `v3d_submit_jobs()` now also handles fence attachment and job put on success, becoming the single entry point. The old `v3d_job_init()`, `v3d_job_allocate()`, and `v3d_job_deallocate()` are removed as dead code. Clean. No issues beyond the inherited bounds check concern from patch 8. --- Generated by Claude Code Patch Reviewer