From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: mm: Use usable VRAM region for buddy allocator
Date: Fri, 27 Feb 2026 14:25:29 +1000
Message-ID: <review-patch11-20260224225323.3312204-12-joelagnelf@nvidia.com>
In-Reply-To: <20260224225323.3312204-12-joelagnelf@nvidia.com>
References: <20260224225323.3312204-1-joelagnelf@nvidia.com> <20260224225323.3312204-12-joelagnelf@nvidia.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

This is the key integration patch. The `Cell<BootParams>` pattern:
```rust
let boot_params: Cell<BootParams> = Cell::new(BootParams {
    usable_vram_start: 0,
    usable_vram_size: 0,
});
```
This is used to shuttle data from the `gsp_static_info` field initializer to the `mm` field initializer within `try_pin_init!`. It works because `Cell` is single-threaded and the init is sequential. However, this is an unusual pattern -- it would be clearer to refactor `Gpu::new()` into two phases: boot GSP first, then construct the Gpu struct with all the data available.

---
Generated by Claude Code Patch Reviewer