public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: ARM: dts: imx6ul-var-som: add support for EC configuration option (ENET1)
Date: Tue, 03 Mar 2026 12:58:07 +1000	[thread overview]
Message-ID: <review-patch11-20260302190953.669325-12-hugo@hugovil.com> (raw)
In-Reply-To: <20260302190953.669325-12-hugo@hugovil.com>

Patch Review

**Issue 1 (Critical, same as patch 9)**: The `pinctrl_enet1_gpio` in `imx6ull-var-som.dtsi` uses `MX6ULL_PAD_SNVS_TAMPER0__GPIO5_IO00` under `&iomuxc` — this must be `&iomuxc_snvs`.

**Issue 2 (Significant)**: There is a duplicate definition of `ethphy0: ethernet-phy@1` — it appears in both `imx6ul-var-som-enet2.dtsi` (added by this patch) and `imx6ul-var-som-enet1.dtsi`. When both are included in the `-full` boards, the same node is defined twice with the same label at the same path. While DTS merge semantics allow this (properties get overwritten with identical values), it is confusing and error-prone.

A cleaner approach would be to have `ethphy0` defined only in `enet1.dtsi` (since it's the ENET1 PHY), and use the `mdio_enet2` label from enet2.dtsi to place it. Don't duplicate it in enet2.dtsi.

**Issue 3 (Significant)**: The author acknowledges the design problem in the `---` notes:
> In order for this to work, imx6ul-var-som-enet2.dtsi must be included first, and thus enabled, even if not used. Maybe there is a better way to support both independently, but I'm not sure how.

This forced dependency on enet2.dtsi for enet1 to work is fragile. Consider defining the shared MDIO bus in the common dtsi or in a separate shared file, rather than making enet1 depend on enet2's internal implementation.

**Issue 4**: The `pinctrl_enet1_mdio` group from the original code was dropped. The original had:
```c
pinctrl-0 = <&pinctrl_enet1>, <&pinctrl_enet1_gpio>, <&pinctrl_enet1_mdio>;
```
The new version has:
```c
pinctrl-0 = <&pinctrl_enet1>, <&pinctrl_enet1_gpio>;
```
This seems intentional since fec1 now uses fec2's MDIO bus, but should be noted in the commit message.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-03  2:58 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 19:03 [PATCH 00/14] var-som-6ul: improve support for variants Hugo Villeneuve
2026-03-02 19:03 ` [PATCH 01/14] ARM: dts: imx6ul-var-som: fix warning for non-existent dc-supply property Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 02/14] ARM: dts: imx6ul-var-som: fix warning for boolean property with a value Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 03/14] ARM: dts: imx6ul-var-som: change incorrect VAR-SOM-6UL model name Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 04/14] dt-bindings: arm: fsl: " Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 05/14] dt-bindings: arm: fsl: add variscite,var-som-imx6ull Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 06/14] ARM: dts: imx6ul-var-som: Factor out common parts for all CPU variants Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 07/14] ARM: dts: imx6ul-var-som-concerto: " Hugo Villeneuve
2026-03-02 20:50   ` Frank Li
2026-03-02 21:07     ` Hugo Villeneuve
2026-03-02 21:28       ` Frank Li
2026-03-02 21:36         ` Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 08/14] ARM: dts: imx6ul-var-som: factor out SD card support Hugo Villeneuve
2026-03-02 20:54   ` Frank Li
2026-03-02 21:15     ` Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 09/14] ARM: dts: imx6ul-var-som: add proper Wifi and Bluetooth support Hugo Villeneuve
2026-03-02 20:59   ` Frank Li
2026-03-02 21:42     ` Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 10/14] ARM: dts: imx6ul-var-som: factor out ENET2 ethernet support Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 11/14] ARM: dts: imx6ul-var-som: add support for EC configuration option (ENET1) Hugo Villeneuve
2026-03-03  2:58   ` Claude Code Review Bot [this message]
2026-03-02 19:03 ` [PATCH 12/14] ARM: dts: imx6ul-var-som: factor out audio support Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 13/14] dt-bindings: display/lvds-codec: add ti,sn65lvds93 Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-02 19:03 ` [PATCH 14/14] ARM: dts: imx6ul-var-som: add support for LVDS display panel Hugo Villeneuve
2026-03-03  2:58   ` Claude review: " Claude Code Review Bot
2026-03-03  2:58 ` Claude review: var-som-6ul: improve support for variants Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch11-20260302190953.669325-12-hugo@hugovil.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox