From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: add gen_bootloader firmware to ModInfoBuilder Date: Mon, 09 Mar 2026 09:15:15 +1000 Message-ID: In-Reply-To: <20260306-turing_prep-v11-11-8f0042c5d026@nvidia.com> References: <20260306-turing_prep-v11-0-8f0042c5d026@nvidia.com> <20260306-turing_prep-v11-11-8f0042c5d026@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `needs_fwsec_bootloader()` to `Chipset` and uses it to conditionally add the `gen_bootloader` firmware entry. The method correctly identifies Turing + GA100 as the chipsets needing it. The change to pass `Chipset` instead of `&str` to `make_entry_chipset` is a good improvement. No issues. --- Generated by Claude Code Patch Reviewer