From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/adreno: use new helper to set ubwc_swizzle Date: Mon, 09 Mar 2026 08:32:17 +1000 Message-ID: In-Reply-To: <20260306-ubwc-rework-v1-11-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> <20260306-ubwc-rework-v1-11-9cfdff12f2bb@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Replaces `cfg->ubwc_swizzle` with `qcom_ubwc_swizzle(cfg)` in a6xx, a8xx, and `adreno_get_param`. Notable that `MSM_PARAM_UBWC_SWIZZLE` in the UAPI path now goes through the helper: ```c - *value = adreno_gpu->ubwc_config->ubwc_swizzle; + *value = qcom_ubwc_swizzle(adreno_gpu->ubwc_config); ``` This is important for userspace compatibility -- the returned value must remain the same. --- Generated by Claude Code Patch Reviewer