From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Apply drm_bridge_connector helper Date: Tue, 10 Mar 2026 11:39:09 +1000 Message-ID: In-Reply-To: <20260310012458.169272-12-damon.ding@rock-chips.com> References: <20260310012458.169272-1-damon.ding@rock-chips.com> <20260310012458.169272-12-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This is the core patch of the series. Key changes: 1. **Connector functions =E2=86=92 bridge functions**: `analogix_dp_get_mod= es` =E2=86=92 `analogix_dp_bridge_get_modes`, `analogix_dp_detect` =E2=86= =92 `analogix_dp_bridge_detect`, `analogix_dp_atomic_check` =E2=86=92 `anal= ogix_dp_bridge_atomic_check`. The migration looks correct. 2. **Bridge ops determination in `analogix_dp_bind()`**: ```c if (dp->plat_data->panel) bridge->ops =3D DRM_BRIDGE_OP_MODES | DRM_BRIDGE_OP_DETECT; else bridge->ops =3D DRM_BRIDGE_OP_EDID | DRM_BRIDGE_OP_DETECT; ``` This is correct - panels provide modes via `get_modes`, while monitors/brid= ges provide EDID. 3. **CRC functions** - The `analogix_dp_start_crc`/`stop_crc` now use `drm_= bridge_chain_get_first_bridge()` and check `bridge->type !=3D DRM_MODE_CONN= ECTOR_eDP`. This is **fragile** - if the bridge chain order changes or anot= her bridge with the same type is present, this breaks. However, it's a prag= matic approach for the current driver topology. 4. **`analogix_dp_bridge_detect()` now returns `connector_status_connected`= for `next_bridge`**: ```c if (dp->plat_data->panel || dp->plat_data->next_bridge) return connector_status_connected; ``` This is correct - a downstream bridge implies a fixed connection. 5. **Bridge connector initialization** in both rockchip and exynos bind fun= ctions is done correctly with error handling. --- Generated by Claude Code Patch Reviewer