From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/dp: Add member to intel_dp to store AS SDP v2 support Date: Thu, 12 Mar 2026 06:55:30 +1000 Message-ID: In-Reply-To: <20260311113611.3393194-12-ankit.k.nautiyal@intel.com> References: <20260311113611.3393194-1-ankit.k.nautiyal@intel.com> <20260311113611.3393194-12-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Reads `DP_AS_SDP_FAVT_PAYLOAD_FIELDS_PARSING_SUPPORTED` from DPCD 0x2214 and stores it as `as_sdp_v2_supported`. Clean. **Minor:** The `drm_dp_dpcd_read_byte()` error check uses `< 0` but `drm_dp_dpcd_readb()` returns the number of bytes read (1 on success). Could check `!= 1` for robustness, though `< 0` catches actual errors. --- Generated by Claude Code Patch Reviewer